job: add is_branch and is_tag functions#27
Open
bergzand wants to merge 1 commit intomurdock-ng:mainfrom
Open
Conversation
bergzand
force-pushed
the
pr/refactor_is_ref
branch
2 times, most recently
from
3463b0b to
b9e98a5
Compare
Contributor
Author
|
I don't know why the style check is suddenly complaining about existing code, maybe mypy lost track of the |
bergzand
force-pushed
the
pr/refactor_is_ref
branch
from
b9e98a5 to
7a1e9a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple refactor to expose an
is_tagandis_branchto thejobclass and replace the relevant conditionals in most places to use these functions